fix(aria-allowed-role): updates the allowed roles for the wbr element to none and presentation #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to issue dequelabs#3177
|
|
|
Thanks for the pr. Should we also update the |
|
Hi @straker. Nope this is good to go. We are matching the br element here, not the b element. So aside from the aria-hidden we spoke of in the issue related to this pr, this update is all that’s needed for updating the allowed roles. |
straker
approved these changes
Oct 8, 2021
|
Reviewed for security |
straker
changed the title
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the allowed roles of the
wbrelement from "all roles", tononeandpresentationonly.related to issue #3177 (but does not entirely close it)