-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'aria-allowed-attr' fails instead of returning "needs review" when generic elements use 'aria-label' and 'aria-labelledby' #2933
Comments
@iamrafan Thank you for reporting the issue. I'm not sure how that slipped by us but I'm going to try to have a fix ready and released ASAP. |
@WilcoFiers Thanks for taking this on, as a high priority |
To be clear, there is a problem if you put |
Verified with the axe-core-develop branch code base with axe-core4.2.0 "audio,applet, canvas, dl, embed, iframe, input, label, meter, object, svg, video" with the below test snippet:
Passing results: Failing results: |
Hi i wanted to check if this fix was released yet? I am still having issues with false positive on In my case is a color picker component. That generates the element source But the axe dev tools raises a |
This should be out in the latest version 4.3.1. |
aria-allowed-attr
fails a few use cases of generic elements usingaria-label
,aria-labelledby
and returnsincomplete
for a few other casesCases 1 to 6 in the examples below should return
incomplete
instead of afailure
Demo link: https://codepen.io/iamrafan/full/abJdjYw
Product: axe-core
Expectation: Return all the usages of ARIA 1.2 prohibited states and properties on generic elements as
needs review
Motivation: Let the users review the issues instead of failing them
The text was updated successfully, but these errors were encountered: