Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getStandards): Read standards from utils #2903

Merged
merged 2 commits into from
May 2, 2021
Merged

Conversation

WilcoFiers
Copy link
Contributor

Should have made this info available before. Not sure why we overlooked that.

Closes issue #2889

@WilcoFiers WilcoFiers requested a review from a team as a code owner April 28, 2021 19:50
lib/core/utils/get-standards.js Outdated Show resolved Hide resolved
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function seems unnecessary. Why would someone use it rather than just doing import standards from '../standards'?

@WilcoFiers
Copy link
Contributor Author

@stephenmathieson I'm adding this so we can use the standards objects outside of axe-core. Makes it a little easier to use them in custom evaluate functions and the like.

@stephenmathieson
Copy link
Member

Should this be considered a feature commit since it's adding something to the public API?

@WilcoFiers
Copy link
Contributor Author

@stephenmathieson If it was added to axe., then yes it would have been a feature. Things in commons / utils are not treated as new features, since we need to be able to add to this as part of fixing bugs.

@WilcoFiers WilcoFiers merged commit f1a0368 into develop May 2, 2021
@WilcoFiers WilcoFiers deleted the get-standards branch May 2, 2021 15:29
straker added a commit that referenced this pull request May 18, 2021
* fix(getStandards): Read standards from utils

* Update lib/core/utils/get-standards.js

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants