Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty-table-header is documented as being able to fail despite specifying reviewOnFail: true #2894

Closed
dbjorge opened this issue Apr 27, 2021 · 2 comments
Assignees
Labels
docs Documentation changes pr A pr has been created for the issue
Milestone

Comments

@dbjorge
Copy link
Contributor

dbjorge commented Apr 27, 2021

rule-descriptions.md documents the new empty-table-header rule as having Issue Type failure, needs review, but I think this should probably just be needs review based on the rule's config specifying "reviewOnFail": true and the rule only having pass/incomplete integration test cases.

Product: axe-core

Expectation: Docs should match config/tests

Actual: Docs and config/tests don't match

Motivation: We'd like to understand whether the docs vs the implementation are the intended behavior, so we can adjust our documentation/ruleset accordingly in Accessibility Insights


axe-core version: 4.2.0
axe-webdriver, extension or other integration version: n/a

Browser and Assistive Technology versions: n/a

For Tooling issues:
- Node version: n/a
- Platform:  n/a
@WilcoFiers
Copy link
Contributor

Thanks for the report @dbjorge! We'll be sure to fix that.

@straker
Copy link
Contributor

straker commented Jun 28, 2021

Fixed in #2986 and #2987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation changes pr A pr has been created for the issue
Projects
None yet
Development

No branches or pull requests

4 participants