Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region rule does not account for absolute URLs in skiplinks #2791

Closed
WilcoFiers opened this issue Feb 8, 2021 · 1 comment
Closed

Region rule does not account for absolute URLs in skiplinks #2791

WilcoFiers opened this issue Feb 8, 2021 · 1 comment
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Milestone

Comments

@WilcoFiers
Copy link
Contributor

This course page creates 3 issues in the region rule: https://dequeuniversity.com/class/ux2/toc The ones on the "next" links are legit, those should be findable through landmarks. The skiplink however should have been excluded The URL "class/ux2/toc#content" is clearly a reference to another element on the same page. The rule should understand this.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Feb 8, 2021
@WilcoFiers WilcoFiers added this to the axe-core 4.2 milestone Feb 8, 2021
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.2, axe-core 4.3 Apr 28, 2021
@straker straker added the pr A pr has been created for the issue label Jun 10, 2021
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.3, Axe-core 4.4 Nov 10, 2021
@straker straker removed this from the Axe-core 4.4 milestone Nov 10, 2021
@WilcoFiers WilcoFiers added this to the Axe-core 4.4 milestone Dec 14, 2021
@padmavemulapati
Copy link

Valdiated with the latest axe-core dev branch code base,

earlier, it was finding region rule for skiplinks as well next links available in the page https://dequeuniversity.com/class/ux/toc
image

As the suggested fix, Region rule does not account for skiplinks, with the latest code, not seeing failure for skiplinks
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

3 participants