Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this Landmark Best Practice Issue accurate, or did axe make an overcall? #2690

Closed
goodwitch opened this issue Dec 15, 2020 · 4 comments
Closed
Assignees
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule

Comments

@goodwitch
Copy link
Contributor

Issue: I ran axe on this page http://test.austinfree.net/ (as a Judge for Knowbility's AIR competition).
The following Best Practice issue is being thrown: 'All page content must be contained by landmarks"
on the video player that is within an iframe that is within <main>.

Expectation: I was wondering if the iframe inside main was enough to count this player as being within a landmark, or if additional landmark need to be added within the iframe.


axe-core version:4.0.2
axe-extension: version 4.6.0

Browser and Assistive Technology versions:
Firefox: 83.0

For Tooling issues:
- Platform:  Mac 11.0.1
@WilcoFiers
Copy link
Contributor

You are correct. That needs to be fixed. Looks like we didn't properly fix #2330 @straker. Sorry Glenda, we'll get it resolved ASAP.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Dec 16, 2020
@svinkle
Copy link

svinkle commented Mar 1, 2021

@WilcoFiers Any update to this? We're running into the same issue with YouTube embeds elsewhere. Thanks.

@padmavemulapati
Copy link

Validated on test page: http://test.austinfree.net/
able to reproduce using axe-expert, seeing Best Practice issue on region saying "All page content must be contained by landmarks"
image

and seeing the fix in the latest develop branch code- axe-core (9th July,2021)
not seeing any issue either violation or Best-practice on region within iframe that is within

.

image

@WilcoFiers WilcoFiers added this to the Axe-core 4.4 milestone Nov 10, 2021
@straker straker removed this from the Axe-core 4.4 milestone Nov 10, 2021
@WilcoFiers
Copy link
Contributor

This could have been closed some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

6 participants