Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(standards/aria-roles): add presentational children property #2689

Merged
merged 1 commit into from
Dec 15, 2020
Merged

feat(standards/aria-roles): add presentational children property #2689

merged 1 commit into from
Dec 15, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 14, 2020

Required for #601. Using this we can do the following for the rule:

  1. look for all [role] elements and match by any roles that have childrenPresentational: true
  2. look at all descendants of said elements and return false if any element is focusable (using dom.isFocusable)

@straker straker requested a review from a team as a code owner December 14, 2020 23:26
@straker straker merged commit 78c239c into develop Dec 15, 2020
@straker straker deleted the presentaional-children branch December 15, 2020 16:07
@WilcoFiers WilcoFiers mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers