Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(implilcit-role): use type property instead of attribute to resolve input role #2547

Merged
merged 2 commits into from
Oct 9, 2020
Merged

fix(implilcit-role): use type property instead of attribute to resolve input role #2547

merged 2 commits into from
Oct 9, 2020

Conversation

shankarshastri
Copy link
Contributor

@shankarshastri shankarshastri commented Oct 8, 2020 •
edited by straker
Loading

Closes issue: #2514 (axe should be aware of input type default of text )

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@shankarshastri shankarshastri requested a review from a team as a code owner October 8, 2020 16:34
@shankarshastri
Copy link
Contributor Author

@straker , Please review this.

WilcoFiers
WilcoFiers previously requested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, also can you please update the issue title to describe the fix?

lib/commons/standards/implicit-html-roles.js Outdated Show resolved Hide resolved
@shankarshastri shankarshastri changed the title Fixes #2514 Fixes #2514 (axe should be aware of input type default of text) Oct 9, 2020
@straker straker changed the title Fixes #2514 (axe should be aware of input type default of text) fix(implilcit-role): use type property instead of attribute to resolve input role Oct 9, 2020
@straker straker added the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Oct 9, 2020
WilcoFiers
WilcoFiers approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for security.

@WilcoFiers
Copy link
Contributor

@shankarshastri Thank you for the pull request!

@WilcoFiers WilcoFiers merged commit 35e853d into dequelabs:develop Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shankarshastri @WilcoFiers @straker