Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual-node): default and lowercase type property #2350

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 8, 2020

Allows us to do input property matches with case insensitivity for serial and virtual nodes.

const input = document.createElement('input');
input.setAttribute('type', 'BUTTON');
const vNode = axe.utils.getFlattenedTree(fixture)[0];

commons.matches(vNode, {
  properties: {
    type: 'button'
  }
}); // true

const serialNode = new axe.SerialVritualNode({
  nodeName: 'input',
  attributes: {
    type: 'BUTTON'
  }
});

commons.matches(serialNode, {
  properties: {
    type: 'button'
  }
}); // true

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 8, 2020 17:03
lib/core/base/virtual-node/virtual-node.js Outdated Show resolved Hide resolved
@straker straker merged commit f6b3484 into develop Jul 10, 2020
@WilcoFiers WilcoFiers deleted the input-type-prop branch January 30, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants