fix(bypass): find headings in iframes #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![axe-linter[bot]](https://avatars.githubusercontent.com/in/60252?s=60&v=4){kind=small}
jeeyyy
previously requested changes
Jun 19, 2020
WilcoFiers
previously requested changes
Jun 19, 2020
Comment on lines
+5
to
+6
| if (windowIsTopMatches(node)) { | ||
| return !!node.querySelector('a[href]'); |
There was a problem hiding this comment.
I'm kind of confused about what you are trying to accomplish here. I don't see how pages having native links is relevant to whether or not they need a mechanism for bypassing repeating content.
There was a problem hiding this comment.
The original matches function required a page link before testing the entire page. Without one, the iframes (which don't have anchors) would not be tested for headings or landmarks. As to why we require the link in the first place, I have no idea.
WilcoFiers
previously requested changes
Jun 26, 2020
.github/axe-linter.yml
Outdated
| - CHANGELOG.md | ||
| - test/**/* |
There was a problem hiding this comment.
This needs a separate PR.
This reverts commit be62002.
WilcoFiers
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to modify the bypass matches function to only look for anchor elements on the top level. Inside iframes we should still run and find any bypassable blocks.
The iframe tests were mostly copied from
page-has-heading-oneintegration tests.Closes issue: #2105
Reviewer checks
Required fields, to be filled out by PR reviewer(s)