feat(matches): add explicitRole, implicitRole, and semanticRole matches functions #2286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific matches functions are needed to know when to look at just the explicit role, just the implicit role, or the semantic role. This follows the ACT standard of naming.
Note: getting the role matches to work with
SerialVirtualNode
will require a rewrite ofgetRole
to use the virtual node to access the role attribute, which will require ensuring every test that usesgetRole
at any point to set up the virtual tree, which is a lot of tests. That will be its own pr after #2281 is merged.Also cleaned up the imports while I was in the code.
Closes issue: #1349
Reviewer checks
Required fields, to be filled out by PR reviewer(s)