Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matches): add explicitRole, implicitRole, and semanticRole matches functions #2286

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 11, 2020

Specific matches functions are needed to know when to look at just the explicit role, just the implicit role, or the semantic role. This follows the ACT standard of naming.

Note: getting the role matches to work with SerialVirtualNode will require a rewrite of getRole to use the virtual node to access the role attribute, which will require ensuring every test that uses getRole at any point to set up the virtual tree, which is a lot of tests. That will be its own pr after #2281 is merged.

Also cleaned up the imports while I was in the code.

Closes issue: #1349

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner June 11, 2020 20:16
@straker straker merged commit 30efbff into develop Jun 12, 2020
@straker straker deleted the role-matchers branch June 12, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants