Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global option for a rule to report "incomplete" instead of "failed" #2186

Closed
WilcoFiers opened this issue Apr 28, 2020 · 4 comments
Closed

Add global option for a rule to report "incomplete" instead of "failed" #2186

WilcoFiers opened this issue Apr 28, 2020 · 4 comments
Assignees
@straker
Labels
configuration rules / checks customisation
Milestone
Axe-core 4.0

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Apr 28, 2020 •
edited
Loading

To improve configurability of axe-core, we'd like to have an option be available, either at the rule level or at the check level, to have its violations reported as incomplete instead.
@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone Apr 28, 2020
@WilcoFiers WilcoFiers added the configuration rules / checks customisation label Apr 28, 2020
@straker straker mentioned this issue May 15, 2020
Merged
2 tasks
@straker straker self-assigned this May 15, 2020
@mejiaj mejiaj mentioned this issue May 15, 2020
Closed
@straker
Copy link
Contributor

straker commented May 18, 2020

qa: create custom rule that overrides a current rule.id, then set reviewOnFail to true. Find a page that fails that rule and verify the rule instead returns as needs review:

axe.configure({
  rules: [{
    id: 'region',
    reviewOnFail: true
  }]
});

@padmavemulapati
Copy link

For regoin rule fail testfile , <body> <div>hello</div> foobar </body>
initially it is in failure:
image
Then configured with :
axe.configure({ rules: [{ id: 'region', reviewOnFail: true }] });
we can see the regoin rule into incomplete, which is expected to this cofiguration.
image

@WilcoFiers WilcoFiers reopened this Jul 30, 2020
@WilcoFiers
Copy link
Contributor Author

This still needs documentation.

@WilcoFiers WilcoFiers mentioned this issue Jul 30, 2020
Closed
@straker
Copy link
Contributor

straker commented Jul 30, 2020

Closed via #2429

@straker straker closed this as completed Jul 30, 2020
@StephenEsser StephenEsser mentioned this issue Oct 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

Labels
configuration rules / checks customisation
Projects
None yet
Milestone
Axe-core 4.0
Development

No branches or pull requests
4 participants
@WilcoFiers @straker @jeankaplansky @padmavemulapati