-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional override for custom color-contrast ratio #2175
Comments
Thanks for the feature request. This is actually something we've been looking into recently to expand our checks to make them more configurable. |
One other thing to consider here, the logic for deciding whether or not the color-contrast rule passes sits in the hasValidContrastRatio method. I think that's a pretty odd place for that logic to live. Instead I think that needs to be moved to the check, which would also make it easier to configure the check. |
Here are the options we're thinking of adding to the color-contrast evaluate method:
|
Verified with the latest axe-core(v3.5.5), there were checks for color-contrast pass/fail based on the threashold for and |
Added to internal release notes 7/27/2020 |
Feature Request
Add an optional override for setting the desired color-contrast ratio.
Details
Our team has been developing a lowlight theme for our UI applications. The theme can be demoed here: https://engineering.cerner.com/terra-core/components by selecting the lowlight theme from the dropdown menu in the upper-right hand corner and navigating around the site.
Lowlight theme is different than "dark mode". Lowlight theme is intended to be used in a dimly lit setting. Radiology/x-ray rooms for example. Our lowlight theme is driven by slightly different color-contrast ratio standards.
We'd like the ability to test the lowlight theme against a different set of color-contrast settings rather than disable the color-contrast rule entirely.
The text was updated successfully, but these errors were encountered: