Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page-has-heading-one): find screen-reader only headings #2065

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 26, 2020

Take into account screen-reader only elements

Closes issue: #2056

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner February 26, 2020 20:14
@straker straker changed the title fix(page-has-heading-one): find sreen-ready only headings fix(page-has-heading-one): find screen-ready only headings Feb 26, 2020
@straker straker changed the title fix(page-has-heading-one): find screen-ready only headings fix(page-has-heading-one): find screen-reader only headings Feb 26, 2020
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add integration tests for page-has-heading-one and page-has-main?

@straker straker merged commit 4c4c41a into develop Feb 28, 2020
@straker straker deleted the findElmSR branch February 28, 2020 17:05
straker added a commit that referenced this pull request Mar 6, 2020
* fix(page-has-heading-one): find sreen-ready only headings

* integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants