Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(region): ignore direct child text nodes of body #2050

Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix(region): ignore direct child text nodes of body #2050

merged 1 commit into from
Feb 18, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 17, 2020 •
edited by WilcoFiers
Loading

We should ignore text nodes that are direct children of body since we cannot target the text node itself and saying "body must be contained within a landmark" doesn't make sense.

Closes issue: #2049

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner February 17, 2020 21:21
@straker straker merged commit af6899e into develop Feb 18, 2020
@straker straker deleted the regionBody branch February 18, 2020 22:42
straker added a commit that referenced this pull request Mar 6, 2020
@straker
fix(region): ignore direct child text nodes of body (#2050)
fde31d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers