fix(preload): reject promise axe.utils.preload when XHR fails
#2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously approved these changes
Feb 3, 2020
straker
reviewed
Feb 3, 2020
| @@ -66,7 +66,7 @@ axe.utils.getPreloadConfig = function getPreloadConfig(options) { | |||
| if ( | |||
| options.preload.timeout && | |||
| typeof options.preload.timeout === 'number' && | |||
| !Number.isNaN(options.preload.timeout) | |||
| !isNaN(options.preload.timeout) | |||
There was a problem hiding this comment.
Number.isNaN does not exist in IE11, and was causing the timeout test to fail, but not because of the timeout (this was only discovered when we added looking at the error message in the test)
straker
approved these changes
Feb 3, 2020
WilcoFiers
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preload assets did not reject with
axios.getfailed.This meant that before this fix, axe.run waited till preload timeout kicked in.
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)