Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): support IE extension context #2008

Merged
merged 1 commit into from
Feb 3, 2020
Merged

fix(color-contrast): support IE extension context #2008

merged 1 commit into from
Feb 3, 2020

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Feb 3, 2020 •
edited by straker
Loading

msElementsFromPoint in IE extensions can return null instead of an empty array where the point is outside the viewport. This ensures such a scenario doesn't cause color-contrast to bail.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@WilcoFiers
fix(color-contrast): support IE extension context
9588afc 
msElementsFromPoint in IE extensions can return null instead of
an empty array.
@WilcoFiers WilcoFiers requested a review from a team as a code owner February 3, 2020 11:09
straker
straker approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a note to look into if we need this function anymore or if we can use dom.getElementStack

@WilcoFiers WilcoFiers merged commit 62e31ea into develop Feb 3, 2020
@WilcoFiers WilcoFiers deleted the ie-elementsFromPoint branch February 3, 2020 20:26
straker pushed a commit that referenced this pull request Feb 4, 2020
@WilcoFiers @straker
fix(color-contrast): support IE extension context (#2008)
cd651a0 
msElementsFromPoint in IE extensions can return null instead of
an empty array.
straker pushed a commit that referenced this pull request Feb 4, 2020
@WilcoFiers @straker
fix(color-contrast): support IE extension context (#2008)
a54bf4f 
msElementsFromPoint in IE extensions can return null instead of
an empty array.
straker pushed a commit that referenced this pull request Feb 4, 2020
@WilcoFiers @straker
fix(color-contrast): support IE extension context (#2008)
64f6910 
msElementsFromPoint in IE extensions can return null instead of
an empty array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilcoFiers @straker