Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v1-reporters): Add failureSummary to incomplete results #1972

Merged
merged 1 commit into from
Jan 13, 2020
Merged

feat(v1-reporters): Add failureSummary to incomplete results #1972

merged 1 commit into from
Jan 13, 2020

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented Jan 7, 2020 •
edited by WilcoFiers
Loading

This change populates the failureSummary field in the v1 reporter for results categorized as incomplete. At the time of writing, this field is currently only populated for violations.

Closes issue: #1971

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@jayaddison jayaddison requested a review from a team as a code owner January 7, 2020 13:32
@claassistantio
Copy link

claassistantio commented Jan 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jayaddison
Copy link
Contributor Author

cc @straker @WilcoFiers (mentioning you as folks I've interacted with related to the handling of incomplete results from axe-core, and seen doing recent code reviews - please let me know if there's a preferred approach for requesting formal code review!)

WilcoFiers
WilcoFiers approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you for the contribution!

@WilcoFiers WilcoFiers changed the title feat(core/reporters/v1): Add failureSummary to incomplete results feat(v1-reporters): Add failureSummary to incomplete results Jan 10, 2020
@jayaddison
Copy link
Contributor Author

Glad to help, thanks for the review! :)

@WilcoFiers WilcoFiers merged commit c88883d into dequelabs:develop Jan 13, 2020
@jayaddison jayaddison mentioned this pull request Jan 13, 2020
Closed
@jayaddison jayaddison deleted the add-failureSummary-for-incomplete-results branch January 13, 2020 16:40
@jayaddison jayaddison mentioned this pull request Feb 24, 2020
Merged
@Certary Certary mentioned this pull request Oct 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayaddison @claassistantio @WilcoFiers