-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add Basque (eu) translation #1964
Conversation
@aitorla Thank you so much for putting this together! Really cool. Just to give you some info on these. We are looking for someone independent who can help us review this. It's a little hard to predict how much time that would take, these pull requests tend to take a while to get merged. But it will, for sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took so long, just 1 thing
locales/eu.json
Outdated
"incompleteFallbackMessage": { | ||
"undefined": { | ||
"failureMessage": "Gorabehera hauek zuzentzea (guztiak):{{~it:value}}\n {{=value.split('\\n').join('\\n ')}}{{~}}" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The incompleteFallbackMessage
should just be a string instead of an object (I think we had generated it wrongly before). See https://github.com/dequelabs/axe-core/blob/develop/locales/fr.json#L841 for an example. Also, it should be different than the failureSummaries
message.
The English version of incompleteFallbackMessage
:
axe couldn't tell the reason. Time to break out the element inspector!
Merging this PR, as it has been open for a very long time. If there are any further changes / improvements that need to be made, feel free to open another PR. |
Adds Danish localization of Ace.
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)