feat(landmark-no-duplicate-*): add rule landmark-no-duplicate-main, don't use html as element source for all duplicate rules #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
straker
changed the title
WilcoFiers
previously requested changes
Dec 20, 2019
test/integration/full/landmark-no-duplicate-main/landmark-no-duplicate-main-pass.js
Show resolved
Hide resolved
WilcoFiers
approved these changes
Jan 8, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the element returned from
htmlto whichever is the first duplicate element. However, doing this broke thelandmark-one-mainrule since it did two things at once: ensured there was amainelement and that there was only one. Since I couldn't do both with a non-html selector, I had to split the rule into two rules to cover both casesCloses issue: #978
Reviewer checks
Required fields, to be filled out by PR reviewer(s)