Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(audit): allow runOnly option to accept an array of rules #1889

Merged
merged 3 commits into from
Nov 12, 2019
Merged

feat(audit): allow runOnly option to accept an array of rules #1889

merged 3 commits into from
Nov 12, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 8, 2019 •
edited by WilcoFiers
Loading

runOnly array option will now detect it's type (tag or rule) based on the supplied values.

Closes issue: #1775

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 8, 2019 15:43
stephenmathieson
stephenmathieson previously requested changes Nov 8, 2019
View reviewed changes
lib/core/base/audit.js Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously requested changes Nov 12, 2019
View reviewed changes
doc/API.md Show resolved Hide resolved
@straker
Copy link
Contributor Author

straker commented Nov 12, 2019

Seems our runOnly parameter in axe.d.ts never could accept an array of strings (or tag values).

@straker straker merged commit 38d6a3f into develop Nov 12, 2019
@straker straker deleted the runOnly branch November 12, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@stephenmathieson stephenmathieson stephenmathieson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straker @WilcoFiers @stephenmathieson