Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(is-ligature-icon): rename canvas to canvasContext #1880

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 4, 2019

Tech debt to rename a variable to not collide with the context used in rules.

Closes issue: #1847

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 4, 2019 20:44
@WilcoFiers WilcoFiers changed the title fix(is-ligature-icon): rename canvas to canvasContext chore(is-ligature-icon): rename canvas to canvasContext Nov 5, 2019
@straker straker merged commit de9885d into develop Nov 5, 2019
@straker straker deleted the renameContext branch November 5, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants