Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-required-children): allow reviewEmpty nodes to have empty children #1791

Merged
merged 3 commits into from
Sep 3, 2019
Merged

fix(aria-required-children): allow reviewEmpty nodes to have empty children #1791

merged 3 commits into from
Sep 3, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Aug 28, 2019 •
edited by WilcoFiers
Loading

Allow reviewEmpty roles to have empty children so long as the child does not have a role.

Closes issue: #1762

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner August 28, 2019 16:07
WilcoFiers
WilcoFiers previously requested changes Aug 29, 2019
View reviewed changes
lib/checks/aria/required-children.js Outdated Show resolved Hide resolved
lib/checks/aria/required-children.js Outdated Show resolved Hide resolved
lib/checks/aria/required-children.js Outdated Show resolved Hide resolved
@straker straker merged commit a5d727c into develop Sep 3, 2019
@straker straker deleted the reviewEmptyChildren branch September 3, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers