Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(th-has-data-cells): empty cells will now pass #1659

Merged
merged 5 commits into from
Jul 8, 2019
Merged

fix(th-has-data-cells): empty cells will now pass #1659

merged 5 commits into from
Jul 8, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 26, 2019 •
edited by jeeyyy
Loading

Allow empty cells to pass the check. Only if there are no header cells will the check return undefined.

Linked issue: #741

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

@straker straker requested a review from a team as a code owner June 26, 2019 21:32
scurker
scurker previously requested changes Jun 27, 2019
View reviewed changes
lib/checks/tables/th-has-data-cells.js Outdated Show resolved Hide resolved
jeeyyy
jeeyyy previously approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@jeeyyy jeeyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@straker straker merged commit c7489ab into develop Jul 8, 2019
@straker straker deleted the thNoCells branch July 8, 2019 14:51
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
@straker @WilcoFiers
fix(th-has-data-cells): empty cells will now pass (#1659)
9ca800c 
* fix(th-has-data-cells): empty cells will now pass

* filter headers

* fix test

* find instead of filter

* move test to passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@jeeyyy jeeyyy jeeyyy left review comments

@scurker scurker scurker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@straker @WilcoFiers @scurker @jeeyyy