Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(get-background-color): process tbody, thead, and tfoot when getting background color #1653

Merged
merged 3 commits into from
Jun 26, 2019
Merged

fix(get-background-color): process tbody, thead, and tfoot when getting background color #1653

merged 3 commits into from
Jun 26, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 24, 2019 •
edited by WilcoFiers
Loading

All browsers consistently allowed styling <thead>, <tbody>, and <tfoot> elements. Added them to the getBackroundColor function that includes missing elements from document.elementsFromPoint API.

https://codepen.io/straker/pen/ewRzKr

Linked issue: #823

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@straker straker requested a review from a team as a code owner June 24, 2019 21:08
WilcoFiers
WilcoFiers previously requested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the scope creep. I know that's not your bug, but let's fix it regardless.

lib/commons/color/get-background-color.js Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers changed the title feat(get-background-color): process tbody, thead, and tfoot when getting background color fix(get-background-color): process tbody, thead, and tfoot when getting background color Jun 26, 2019
@straker straker merged commit e114bfd into develop Jun 26, 2019
@straker straker deleted the theadBodyFoot branch June 26, 2019 19:46
@straker straker mentioned this pull request Jun 26, 2019
Merged
4 tasks
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
@straker @WilcoFiers
fix(get-background-color): process tbody, thead, and tfoot when getti…
2023f9f 
…ng background color (#1653)

* feat(get-background-color): process tbody, thead, and tfoot when getting background color

* uppercase nodenme

* fix other nodeName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers