Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: watch integration html and json files #1598

Merged
merged 1 commit into from
May 29, 2019
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented May 29, 2019

Making changes to integration html and json files did not retrigger the npm start build, so you would have to manually quit and restart the process to see changes. The test/integration/index.html file is a generated file so we exclude that file from the watch.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Jason

@straker straker requested a review from a team May 29, 2019 16:53
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@straker straker merged commit 3de0b05 into develop May 29, 2019
@straker straker deleted the watchIntegrationFiles branch May 29, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants