Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: aria-form-field-label #1449

Closed
jeeyyy opened this issue Mar 20, 2019 · 5 comments
Closed

New Rule: aria-form-field-label #1449

jeeyyy opened this issue Mar 20, 2019 · 5 comments
Assignees

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Mar 20, 2019

Some Context:
This is a composite rule that will use some pre-existing checks, to extend the current label rule for a larger set of semantic roles (checkbox, combobox, listbox, menuitemcheckbox, menuitemradio, radio, searchbox, slider, spinbutton, switch, textbox)

aria-form-field-label

Ensures every element with semantic roles of a form field (checkbox, combobox (select elements), listbox, menuitemcheckbox, menuitemradio, radio, searchbox, slider, spinbutton, switch, textbox) has a label.

Tags: wcag2a, wcag412

Matches

  • all of the above semantic roles excluding ones covered by label rule & or any overlapping rules like area-alt, button-name, image-alt.

Checks

any:

  • aria-label (Already exists)
  • aria-labelledby(Already exists)
  • non-empty-title (Already exists)

none:

  • no-implicit-explicit-label
    • "fail": "Element with ARIA role ... must have label",
    • "incomplete": "Element with ARIA role ... cannot have implicit or explicit label"

Related issues

@jeeyyy jeeyyy changed the title New Rule: form-field-label New Rule: aria-form-field-label Apr 4, 2019
@dylanb
Copy link
Contributor

dylanb commented Jun 16, 2019

we should call this aria-input-field-name

@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jun 17, 2019

@dylanb

This got split into 2 rules

  • aria-toggle-field-label and
  • aria-input-field-label

Do you want to change both of them to below?

  • aria-toggle-field-name
  • aria-input-field-name

@WilcoFiers - what do you think?

@dylanb
Copy link
Contributor

dylanb commented Jun 17, 2019

yes, name and this should probably happen before we ship 3.3

@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jun 17, 2019

@dylanb - as the PR's (#1450 & #1610) have been merged, I am closing this issue. If you believe the rules have to be renamed, please reopen the issue & notify.

@jeeyyy jeeyyy closed this as completed Jun 17, 2019
@dylanb
Copy link
Contributor

dylanb commented Jun 19, 2019

Yes, i think we should rename these before releasing 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants