Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass context to rule matches #1370

Merged
merged 1 commit into from
Feb 17, 2019
Merged

feat: pass context to rule matches #1370

merged 1 commit into from
Feb 17, 2019

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Feb 15, 2019 •
edited by WilcoFiers
Loading

Passing the context object to the matches function for rules, to allow for pre-filtering of nodes based on context.

Closes issue: #1359

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested review from stephenmathieson and a team as code owners February 15, 2019 16:24
@jeeyyy jeeyyy mentioned this pull request Feb 15, 2019
Closed
stephenmathieson
stephenmathieson approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilcoFiers WilcoFiers merged commit b374669 into develop Feb 17, 2019
@stephenmathieson stephenmathieson deleted the context-to-matches branch February 18, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeeyyy @WilcoFiers @stephenmathieson