-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): Require unique aria labels in checkboxgroup & radiogroup #1316
Conversation
if (uniqueLabels.length > 0 && sharedLabels.length === 0) { | ||
data.failureCode = 'no-shared-label'; | ||
} else if (uniqueLabels.length === 0 && sharedLabels.length > 0) { | ||
data.failureCode = 'no-unique-label'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not always fail this even when there is no shared label?
@WilcoFiers seems like the change to make @stephenmathieson a code owner broke our ability to approve changes in that code |
Feedback: Just updated axe an ran into this check. We finally could find the issue, we were having, but had to read through the tests and code modifications here to understand what was wrong. This is the message we recieved
The actual problem was, that our radio buttons had a Maybe you should consider improving the message. |
@naltatis Do you think you could create a new issue in this project that references this and also maybe suggest a text that might have helped you figure out what was going on? |
Update the group-labelledby check to enforce that in addition to having a shared label, radiobuttons and checkboxes with the same name also have a unique label. This impacts the checkboxgroup and radiogroup rules.
I merged in a fix from #1314, which changes the gruntfile. We should probably more that PR first.
Closes #1111
Reviewer checks
Required fields, to be filled out by PR reviewer(s)