Skip to content

Commit

Permalink
fix: Add treegrid as allowed parent to rowgroup (#1435)
Browse files Browse the repository at this point in the history
`rowgroup` is allowed a `treegrid` context according to the [ARIA spec](https://www.w3.org/TR/wai-aria-1.1/#rowgroup).

Closes: #1386 

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
  • Loading branch information
straker authored and WilcoFiers committed Mar 20, 2019
1 parent aace2f3 commit 94e9893
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/commons/aria/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,7 @@ lookupTable.role = {
all: ['row']
},
nameFrom: ['author', 'contents'],
context: ['grid', 'table'],
context: ['grid', 'table', 'treegrid'],
implicit: ['tbody', 'thead', 'tfoot'],
unsupported: false
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@
<div role="listitem" id="fail3"></div>
<div role="list" id="pass7" aria-owns="parent"></div>
<div id="parent"><div role="listitem" id="pass8"></div></div>
<div role="grid" id="pass9"><div role="rowgroup" id="pass10">Item 1</div></div>
<div role="table" id="pass11"><div role="rowgroup" id="pass12">Item 1</div></div>
<div role="treegrid" id="pass13"><div role="rowgroup" id="pass14">Item 1</div></div>
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
["#pass5"],
["#pass6"],
["#pass7"],
["#pass8"]
["#pass8"],
["#pass9"],
["#pass10"],
["#pass11"],
["#pass12"],
["#pass13"],
["#pass14"]
]
}

0 comments on commit 94e9893

Please sign in to comment.