fix: Set relatedNodes on color/link-in-block rules (#407)

dequelabs · Jul 7, 2017 · 7fde0fe · 7fde0fe
1 parent 0039977
commit 7fde0fe
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 8 deletions.
diff --git a/lib/checks/color/color-contrast.js b/lib/checks/color/color-contrast.js
@@ -41,14 +41,14 @@ var data = {
 
 this.data(data);
 
-if (!cr.isValid || equalRatio) {
-	this.relatedNodes(bgNodes);
-}
-
 //We don't know, so we'll put it into Can't Tell
 if (fgColor === null || bgColor === null || equalRatio) {
 	missing = null;
 	axe.commons.color.incompleteData.clear();
+	this.relatedNodes(bgNodes);
 	return undefined;
+
+} else if (!cr.isValid) {
+	this.relatedNodes(bgNodes);
 }
 return cr.isValid;
diff --git a/lib/checks/color/link-in-text-block.js b/lib/checks/color/link-in-text-block.js
@@ -24,6 +24,8 @@ while (parentBlock.nodeType === 1 && !isBlock(parentBlock)) {
 	parentBlock = parentBlock.parentNode;
 }
 
+this.relatedNodes([ parentBlock ]);
+
 // TODO: Check the :visited state of the link
 if (color.elementIsDistinct(node, parentBlock)) {
 	return true;

diff --git a/test/checks/color/color-contrast.js b/test/checks/color/color-contrast.js
@@ -212,4 +212,23 @@ describe('color-contrast', function () {
 		assert.equal(checkContext._data.missingData, 'equalRatio');
 		assert.equal(checkContext._data.contrastRatio, 1);
 	});
+
+	it('returns relatedNodes with undefined', function () {
+		var dataURI = 'data:image/gif;base64,R0lGODlhEAAQAMQAAORHHOVSKudfOulrSOp3WOyDZu6QdvCchPGolfO0o/' +
+		'XBs/fNwfjZ0frl3/zy7////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAkA' +
+		'ABAALAAAAAAQABAAAAVVICSOZGlCQAosJ6mu7fiyZeKqNKToQGDsM8hBADgUXoGAiqhSvp5QAnQKGIgUhwFUYLCVDFCrKU' +
+		'E1lBavAViFIDlTImbKC5Gm2hB0SlBCBMQiB0UjIQA7';
+
+		fixture.innerHTML = '<div id="background" style="background:url('+ dataURI +') no-repeat left center; padding: 5px 0 5px 25px;">' +
+			'<p id="target">Text 1</p>' +
+			'</div>';
+
+		var target = fixture.querySelector('#target');
+		assert.isUndefined(checks['color-contrast'].evaluate.call(checkContext, target));
+
+		assert.equal(
+			checkContext._relatedNodes[0],
+			document.querySelector('#background')
+		);
+	});
 });
diff --git a/test/checks/color/link-in-text-block.js b/test/checks/color/link-in-text-block.js
@@ -207,8 +207,17 @@ describe('link-in-text-block', function () {
 
 	});
 
-	it('looks at the :visited state');
-
-	it('looks at selectors using :link');
-
+	it('returns relatedNodes with undefined', function () {
+			var linkElm = getLinkElm({ }, {
+				color: '#000010',
+				backgroundImage: 'url(data:image/gif;base64,R0lGODlhEAAQAMQAAORHHOVSKudfOulrSOp3WOyDZu6QdvCchPGolfO0o/XBs/fNwfjZ0frl3/zy7////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAkAABAALAAAAAAQABAAAAVVICSOZGlCQAosJ6mu7fiyZeKqNKToQGDsM8hBADgUXoGAiqhSvp5QAnQKGIgUhwFUYLCVDFCrKUE1lBavAViFIDlTImbKC5Gm2hB0SlBCBMQiB0UjIQA7)'
+			}, {
+				color: '#000000'
+			});
+			assert.isUndefined(checks['link-in-text-block'].evaluate.call(checkContext, linkElm));
+			assert.equal(
+				checkContext._relatedNodes[0],
+				linkElm.parentNode
+			);
+		});
 });