From 22175b2e4eca5f22e056774baa6d6d1e65681159 Mon Sep 17 00:00:00 2001 From: Wilco Fiers Date: Fri, 14 Apr 2023 14:56:45 +0200 Subject: [PATCH] Revert "feat(rules): deprecate duplicate-id and duplicate-id-active (#3957)" This reverts commit 04a4b5e75825fdb5d41ca1c4eb0c895f44d15115. --- doc/rule-descriptions.md | 4 ++-- lib/rules/duplicate-id-active.json | 3 +-- lib/rules/duplicate-id.json | 3 +-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index 4fe46ae3d9..5206b0c792 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -37,7 +37,9 @@ | [definition-list](https://dequeuniversity.com/rules/axe/4.6/definition-list?application=RuleDescription) | Ensures <dl> elements are structured correctly | Serious | cat.structure, wcag2a, wcag131 | failure | | | [dlitem](https://dequeuniversity.com/rules/axe/4.6/dlitem?application=RuleDescription) | Ensures <dt> and <dd> elements are contained by a <dl> | Serious | cat.structure, wcag2a, wcag131 | failure | | | [document-title](https://dequeuniversity.com/rules/axe/4.6/document-title?application=RuleDescription) | Ensures each HTML document contains a non-empty <title> element | Serious | cat.text-alternatives, wcag2a, wcag242, ACT | failure | [2779a5](https://act-rules.github.io/rules/2779a5) | +| [duplicate-id-active](https://dequeuniversity.com/rules/axe/4.6/duplicate-id-active?application=RuleDescription) | Ensures every id attribute value of active elements is unique | Serious | cat.parsing, wcag2a, wcag411 | failure | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) | | [duplicate-id-aria](https://dequeuniversity.com/rules/axe/4.6/duplicate-id-aria?application=RuleDescription) | Ensures every id attribute value used in ARIA and in labels is unique | Critical | cat.parsing, wcag2a, wcag411 | failure | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) | +| [duplicate-id](https://dequeuniversity.com/rules/axe/4.6/duplicate-id?application=RuleDescription) | Ensures every id attribute value is unique | Minor | cat.parsing, wcag2a, wcag411 | failure | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) | | [form-field-multiple-labels](https://dequeuniversity.com/rules/axe/4.6/form-field-multiple-labels?application=RuleDescription) | Ensures form field does not have multiple label elements | Moderate | cat.forms, wcag2a, wcag332 | needs review | | | [frame-focusable-content](https://dequeuniversity.com/rules/axe/4.6/frame-focusable-content?application=RuleDescription) | Ensures <frame> and <iframe> elements with focusable content do not have tabindex=-1 | Serious | cat.keyboard, wcag2a, wcag211 | failure, needs review | [akn7bn](https://act-rules.github.io/rules/akn7bn) | | [frame-title-unique](https://dequeuniversity.com/rules/axe/4.6/frame-title-unique?application=RuleDescription) | Ensures <iframe> and <frame> elements contain a unique title attribute | Serious | cat.text-alternatives, wcag412, wcag2a | needs review | [4b1c6c](https://act-rules.github.io/rules/4b1c6c) | @@ -151,5 +153,3 @@ Deprecated rules are disabled by default and will be removed in the next major r | :----------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------- | :------- | :--------------------------------------------------------------------------- | :------------------------- | :----------------------------------------------------------------------------------------------------- | | [aria-roledescription](https://dequeuniversity.com/rules/axe/4.6/aria-roledescription?application=RuleDescription) | Ensure aria-roledescription is only used on elements with an implicit or explicit role | Serious | cat.aria, wcag2a, wcag412, deprecated | failure, needs review | | | [audio-caption](https://dequeuniversity.com/rules/axe/4.6/audio-caption?application=RuleDescription) | Ensures <audio> elements have captions | Critical | cat.time-and-media, wcag2a, wcag121, section508, section508.22.a, deprecated | needs review | [2eb176](https://act-rules.github.io/rules/2eb176), [afb423](https://act-rules.github.io/rules/afb423) | -| [duplicate-id-active](https://dequeuniversity.com/rules/axe/4.6/duplicate-id-active?application=RuleDescription) | Ensures every id attribute value of active elements is unique | Serious | cat.parsing, wcag2a-obsolete, wcag411, deprecated | failure | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) | -| [duplicate-id](https://dequeuniversity.com/rules/axe/4.6/duplicate-id?application=RuleDescription) | Ensures every id attribute value is unique | Minor | cat.parsing, wcag2a-obsolete, wcag411, deprecated | failure | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) | diff --git a/lib/rules/duplicate-id-active.json b/lib/rules/duplicate-id-active.json index 80ff8cb371..6edfbc5277 100644 --- a/lib/rules/duplicate-id-active.json +++ b/lib/rules/duplicate-id-active.json @@ -3,8 +3,7 @@ "selector": "[id]", "matches": "duplicate-id-active-matches", "excludeHidden": false, - "enabled": false, - "tags": ["cat.parsing", "wcag2a-obsolete", "wcag411", "deprecated"], + "tags": ["cat.parsing", "wcag2a", "wcag411"], "actIds": ["3ea0c8"], "metadata": { "description": "Ensures every id attribute value of active elements is unique", diff --git a/lib/rules/duplicate-id.json b/lib/rules/duplicate-id.json index bad73ce071..5068a41a0f 100644 --- a/lib/rules/duplicate-id.json +++ b/lib/rules/duplicate-id.json @@ -3,8 +3,7 @@ "selector": "[id]", "matches": "duplicate-id-misc-matches", "excludeHidden": false, - "enabled": false, - "tags": ["cat.parsing", "wcag2a-obsolete", "wcag411", "deprecated"], + "tags": ["cat.parsing", "wcag2a", "wcag411"], "actIds": ["3ea0c8"], "metadata": { "description": "Ensures every id attribute value is unique",