Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

Let's try roave/backward-compatibility-check #3076

Closed
enumag opened this issue Mar 23, 2021 · 3 comments
Closed

Let's try roave/backward-compatibility-check #3076

enumag opened this issue Mar 23, 2021 · 3 comments

Comments

@enumag
Copy link
Member

enumag commented Mar 23, 2021

After finding two more BC breaks in Symplify patch versions today I wanted to leave a constructive feedback instead of just complaining. So I tried to look into what we could add to symplify CI in order to prevent BC brekas in the future. And there actually is a nice package for this which I think is well worth trying out and adding to symplify's CI: https://github.com/Roave/BackwardCompatibilityCheck

@TomasVotruba
Copy link
Member

One of them is false positive.

I'm aware of this package, but never worked with the tool.
If you think it would help the release workflow more clean, I'd be happy to accept the PR.

@enumag
Copy link
Member Author

enumag commented Mar 23, 2021

One of them is false positive.

No it isn't. Changing a major version of a dependency in patch version is a BC break no matter what. At least do it in minor. Never ever do that in patch.

If you needed the update for some new feature in Symplify then that feature should not have been added in a patch version. That's actually a univeral rule - patch versions should fix bugs, not add new features. If a bugfix requires a package major version bump then the bugfix should be postponed too.

I'll try to look into it later.

@TomasVotruba
Copy link
Member

Feel free to contribute when have time. Closing as accepted.

@deprecated-packages deprecated-packages locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants