Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel overriding public folder not symlinking properly #1086

Closed
garygreen opened this issue Mar 10, 2017 · 3 comments
Closed

Laravel overriding public folder not symlinking properly #1086

garygreen opened this issue Mar 10, 2017 · 3 comments
Labels

Comments

@garygreen
Copy link

If you've overridden the public path in laravel from the standard public to e.g. public_html -- the symlinking for the public storage won't work.

Laravel actually provides a command php artisan storage:link that can link public to the storage folder (it will know that you've overriden the path) -- maybe that should be used rather than hardcoding it ?

@antonmedv
Copy link
Member

What will be cool. Can you make a PR with this?

@barryvdh
Copy link
Contributor

barryvdh commented Apr 3, 2017

Would be just

desc('Execute artisan storage:link');
task('artisan:storage:link', function () {
    run('{{bin/php}} {{release_path}}/artisan storage:link');
});

But it does have different checks: https://github.com/laravel/framework/blob/5.4/src/Illuminate/Foundation/Console/StorageLinkCommand.php

@barryvdh
Copy link
Contributor

barryvdh commented Apr 7, 2017

See #1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants