Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Not ignoring Python dependency #667

Closed
YakDriver opened this issue Sep 10, 2019 · 2 comments
Closed

Not ignoring Python dependency #667

YakDriver opened this issue Sep 10, 2019 · 2 comments

Comments

@YakDriver
Copy link

YakDriver commented Sep 10, 2019

Our project maintains compatibility across Python versions 2.6-3.7. This is a portion of our requirements.txt:

pytest==3.2.5;python_version<"2.7" or python_version=="3.3"
pytest==4.6.3;python_version<"3.5" and python_version>="2.7"
pytest==5.1.2;python_version>="3.5"

We want Dependabot to ignore the first two lines but not ignore the third.

We modified the file to use < for the purpose of helping Dependabot ignore these lines. Based on #658, it seems like the < should do the trick. However, Dependabot does not ignore the second line.

Can you offer any suggestion?

@YakDriver YakDriver changed the title Not ignoring same Python dependency with various markers, versions Not ignoring Python dependency Sep 10, 2019
@greysteil
Copy link
Contributor

Fixed by dependabot/dependabot-core@e6d724a. Thanks for the heads up!

@YakDriver
Copy link
Author

Wow. Very responsive. Thanks, @greysteil !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants