Workaround thread safety issue by limiting worker count #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
handle-thread-safety-issue-by-limiting-workers
branch
from
b6f3f20
to
17cdb2d
Compare
|
Oof, the maintainer suggested this workaround, but unfortunately the setting isn't available til |
The original intent of this code was to workaround a thread safety issue. However, according to the `poetry` maintainer, the more "future proof" workaround is [to limit the worker count rather than disable the new installer](python-poetry/poetry#3010 (comment)). The underlying root issue is supposedly resolved in [the upcoming `1.2` release of `poetry`](python-poetry/poetry#3010 (comment)). But until then let's use the cleaner workaround.
jeffwidman
force-pushed
the
handle-thread-safety-issue-by-limiting-workers
branch
from
17cdb2d
to
fd1d6bc
Compare
|
Closing in favor of #5838 |
jeffwidman
added a commit
that referenced
this pull request
Oct 7, 2022
This was added in #3459 to workaround the underlying issue of python-poetry/poetry#3010. However, `poetry` `1.2` fixed the underlying issue, and we are now on `poetry` `1.2.1` so we can remove this workaround. See also: * python-poetry/poetry#3010 (comment) * python-poetry/poetry#3010 (comment) * python-poetry/poetry#3010 (comment) * #5492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of this code was to workaround a thread safety
issue. However, according to the
poetrymaintainer, the more "futureproof" workaround is to limit the worker count rather than disable the
new installer.
The underlying root issue is supposedly resolved in the upcoming
1.2release of
poetry.But until then let's use the cleaner workaround.