Explain update not possible for bundler #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
reviewed
Oct 30, 2020
feelepxyz
approved these changes
Oct 30, 2020
jurre
force-pushed
the
jurre/improve-bundler-helper-errors
branch
6 times, most recently
from
7961ad6
to
a0a87fc
Compare
jurre
changed the title
jurre
force-pushed
the
jurre/improve-bundler-helper-errors
branch
2 times, most recently
from
453d73c
to
07e5dac
Compare
thepwagner
approved these changes
Nov 4, 2020
bundler/lib/dependabot/bundler/update_checker/parent_dependency_resolver.rb
Outdated
Show resolved
Hide resolved
bundler/spec/dependabot/bundler/update_checker/parent_dependency_resolver_spec.rb
Outdated
Show resolved
Hide resolved
bundler/spec/dependabot/bundler/update_checker/parent_dependency_resolver_spec.rb
Outdated
Show resolved
Hide resolved
bundler/spec/dependabot/bundler/update_checker/parent_dependency_resolver_spec.rb
Outdated
Show resolved
Hide resolved
jurre
force-pushed
the
jurre/improve-bundler-helper-errors
branch
from
ba2c145
to
edd78f1
Compare
feelepxyz
approved these changes
Nov 4, 2020
Currently we are actually raising a `can't modify frozen NilClass` error because we attempt to `instance_variable_set` on `nil`, as we try to find `dependency` in the Gemfile. This is a small step towards figuring out what dependency is blocking for an update.
This returns a message from ForceUpdater that explains why a certain update was not possible, by traversing the dependency tree and finding all parent dependencies that are not satisfied by the target version. Few things to improve: - The message is now formatted in the native helper, I would prefer to return raw data from there, and leave any formatting to whatever drives dependabot. - Because we currently depend on the native helper returning an error, it is hard to pass data from the native function to dependabot-core. - We need to call `latest_version_resolvable_with_full_unlock?` in order to hit the error that sets this new message. I'd prefer to be able to just call a method on the UpdateChecker instead. - I dislike having to string compare against the native errors `error_type`, it would be nice to have more granular errors that we can return from there.
Co-authored-by: Pete Wagner <[email protected]>
…endency_resolver_spec.rb Co-authored-by: Pete Wagner <[email protected]>
jurre
force-pushed
the
jurre/improve-bundler-helper-errors
branch
from
8cfa8b2
to
2e50b1d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method
blocking_parent_dependenciestoUpdateChecker, and implements it for bundler. It does this by traversing the dependency tree and finding all parent dependencies that are not satisfied by the target version.It also outputs this in the dry-run script as follows: