Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to update to match poetry's new sources #7839

Open
jeffwidman opened this issue Aug 18, 2023 · 1 comment
Open

need to update to match poetry's new sources #7839

jeffwidman opened this issue Aug 18, 2023 · 1 comment
Labels
F: private-registries 💂‍♂️ Issues about using private registries with Dependabot; may be paired with an R: label. L: python:poetry Python packages via poetry python Dependabot pull requests that update Python code T: tech-debt ⚙️

Comments

@jeffwidman
Copy link
Member

Code improvement description

saw this in passing while skimming the 1.5 changelog, we need to account for it as we have at least one unit test of the deprecated flags, indicating we look for the old keys at least...

<rest of issue description is WIP as I'm about to head to bed, will fill this in more in the morning>

  • Introduce priority key for sources and deprecate flags default and secondary (#7658).
@jeffwidman jeffwidman added T: tech-debt ⚙️ L: python:poetry Python packages via poetry python Dependabot pull requests that update Python code F: private-registries 💂‍♂️ Issues about using private registries with Dependabot; may be paired with an R: label. labels Aug 18, 2023
@donbowman
Copy link

donbowman commented Oct 5, 2023

[[tool.poetry.source]]
url = "https://git.agilicus.com/api/v4/projects/328/packages/pypi/simple"
name = "common"
priority="primary"

[[tool.poetry.source]]
name = "PyPI"
priority = "primary"

this causes dependabot to break.

--------Check platform/messages gunicorn 20.1.0
/bot/vendor/ruby/3.1.0/gems/dependabot-python-0.232.0/lib/dependabot/python/helpers.rb:23:in `run_poetry_command': The Poetry configuration is invalid: (Dependabot::SharedHelpers::HelperSubprocessFailed)
  - [source.0] Additional properties are not allowed ('priority' was unexpected)
  - [source.1] Additional properties are not allowed ('priority' was unexpected)
  - [source.1] 'url' is a required property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: private-registries 💂‍♂️ Issues about using private registries with Dependabot; may be paired with an R: label. L: python:poetry Python packages via poetry python Dependabot pull requests that update Python code T: tech-debt ⚙️
Projects
None yet
Development

No branches or pull requests

3 participants
@jeffwidman @donbowman and others