Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline comments indicating version #5559

Closed
desrosj opened this issue Aug 19, 2022 · 2 comments
Closed

Update inline comments indicating version #5559

desrosj opened this issue Aug 19, 2022 · 2 comments
Labels
L: github:actions GitHub Actions T: feature-request Requests for new features

Comments

@desrosj
Copy link

desrosj commented Aug 19, 2022

This request is specific to GitHub Actions, but it's possible this could be a practice for other package ecosystems.

In WordPress/wordpress-develop, our third-party actions are pinned to a full length commit SHA following the Security Hardening guidelines. Because SHA values are not human readable, an inline comment stating the version number is included at the end of the line (a few examples).

Dependabot is smart enough to update the SHA value, but does not update the version within the comment. I'm not sure if this is a common practice, but it would be great if Dependabot could also update the inline comment.

@desrosj desrosj added the T: feature-request Requests for new features label Aug 19, 2022
@desrosj
Copy link
Author

desrosj commented Aug 19, 2022

An example Dependabot PR where this can be seen: WordPress/wordpress-develop#3112.

@jeffwidman jeffwidman added the L: github:actions GitHub Actions label Sep 22, 2022
@jeffwidman
Copy link
Member

Agreed! We'd love it to, just no one has gotten around to implementing it.

A PR is always welcome if you're interested.

Closing as a duplicate of #4691

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: github:actions GitHub Actions T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

2 participants