Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock files with version 3 are not handled correctly by Dependabot #4361

Closed
ferferga opened this issue Nov 2, 2021 · 3 comments
Closed
Labels
L: javascript:npm npm packages via npm T: bug 🐞 Something isn't working

Comments

@ferferga
Copy link
Contributor

ferferga commented Nov 2, 2021

We recently upgraded to Node 16 and the lockfile version 3 of package-lock.json (the version without backwards-compatible features of the lockfile, see docs here, as we want to enforce always the most current features with the latest LTSs).

Lockfiles proposed by dependabot have massive changes, even when recreated or rebased

Package ecosystem
npm
Package manager version
npm 8.1.0
Language version

  • Node 16

Relevant PRs

@ferferga ferferga added the T: bug 🐞 Something isn't working label Nov 2, 2021
@ferferga ferferga changed the title package-lock files with version 3 are not handled correctly by Dependabotr package-lock files with version 3 are not handled correctly by Dependabot Nov 2, 2021
@xlgmokha xlgmokha added the L: javascript:npm npm packages via npm label Nov 3, 2021
@cedric-anne
Copy link

I confirm the issue. Same problem on this PR: glpi-project/glpi#10035 .

@jeffwidman
Copy link
Member

Closing, as I think this was fixed by the bump to NPM 8:

Please comment if I'm misreading/misunderstanding something, and we can re-open.

@jeffwidman jeffwidman moved this to Done in Dependabot Nov 24, 2022
@cedric-anne
Copy link

Indeed, it seems to be OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript:npm npm packages via npm T: bug 🐞 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants