Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration notes are confusing #3591

Closed
eps1lon opened this issue Apr 29, 2021 · 2 comments
Closed

Migration notes are confusing #3591

eps1lon opened this issue Apr 29, 2021 · 2 comments

Comments

@eps1lon
Copy link

eps1lon commented Apr 29, 2021

We just received the PR that updates the dependabot config to v2 (mui/material-ui#26024).

This PR mentions

please merge this PR and migrate to GitHub-native Dependabot before then.

If I need to "migrate to GitHub-native Dependabot before then" why not mention this first?

-please merge this PR and migrate to GitHub-native Dependabot before then
+please migrate to GitHub-native Dependabot and then merge this PR

I then visited Learn more about migrating to GitHub-native Dependabot to find out how to "migrate to GitHub-native Dependabot".
Though this page says I only have to merge the PR:

Upgrading from Dependabot Preview to GitHub-native Dependabot requires only one step: merge the Upgrade to GitHub-native Dependabot pull request in your repository.

-- https://docs.github.com/en/code-security/supply-chain-security/upgrading-from-dependabotcom-to-github-native-dependabot#upgrading-to-github-native-dependabot

I interpret this as

-In order to keep getting Dependabot updates, please merge this PR and migrate to GitHub-native Dependabot before then.
+In order to keep getting Dependabot updates, please merge this PR.

being sufficient. Is that interpretation accurate?

@jurre
Copy link
Member

jurre commented Apr 29, 2021

Thanks @eps1lon, yep the only thing you have to do is merge the PR, and then you will be migrated to GitHub-native.

cc @asciimike can we clarify that a bit further?

@asciimike
Copy link
Contributor

The majority of folks only need to merge the PR, then they're migrated. Folks who are using private repos/registries need to do a bit more work (grant Dependabot access to the repos/migrate their secrets), then they're migrated. I've clarified the docs (should be published shortly) and I'll work on clarifying the PR.

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants