Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Doesn't handle well poetry dependencies depending on Python version #2503

Closed
alexpdp7 opened this issue Sep 4, 2020 · 7 comments
Closed
Labels
T: bug 🐞 Something isn't working

Comments

@alexpdp7
Copy link

alexpdp7 commented Sep 4, 2020

Package manager/ecosystem

Python Poetry.

https://github.com/alexpdp7/caw/blob/master/pyproject.toml#L14

My project supports Python 3.6, 3.7 and 3.8, hence:

python = ">=3.6, <3.8"

The project uses dataclasses, so on 3.6 I install a backport:

dataclasses = { version = "0.7", python = ">=3.6,<3.7" }

I think this worked OK, but recently Dependabot started spamming me with issues:

alexpdp7/caw#41

, which seem to complain about this issue.

@alexpdp7 alexpdp7 added the T: bug 🐞 Something isn't working label Sep 4, 2020
@chris48s
Copy link

Dependabot has also recently started failing with

[SolverProblemError]
The current project's Python requirement (^3.6) is not compatible with some of the required packages Python requirement:
  - dataclasses requires Python >=3.6, <3.7

on one of my repos too ( https://github.com/chris48s/mark-sideways ), although it is caused by effectively the same condition in one of my transitive dependencies: https://github.com/willmcgugan/rich/blob/a424fafc5654346b5d6e2db28ad19aad10040581/pyproject.toml#L27

I guess this is a manifestation of python-poetry/poetry#2386 as opposed to a bug in dependabot itself.

Strangely, I'm unable to reproduce this locally with python 3.8/poetry 1.0.10 (although the last post in that linked issue says this is still an issue in that build, apparently)

What version of poetry does dependabot use? (I don't think the error log on my repo tells me)

@jurre
Copy link
Member

jurre commented Oct 6, 2020

We're currently on Poetry 1.0.10, and I'm in the process of upgrading to to 1.1.1 @chris48s

@chris48s
Copy link

chris48s commented Oct 7, 2020

Hopefully that upgrade will resolve it 🤞

@chris48s
Copy link

chris48s commented Oct 9, 2020

I've now had a successful dependabot run on that repo

@jurre
Copy link
Member

jurre commented Oct 9, 2020

I've now had a successful dependabot run on that repo

Happy to hear it! Let's keep this open for a bit longer to make sure it's really resolved, please let me know if you spot anything weird

@alexpdp7
Copy link
Author

alexpdp7 commented Oct 9, 2020

It seems to be also working for me.

@jurre
Copy link
Member

jurre commented Oct 9, 2020

It seems to be also working for me.

Awesome! Alright I'm going to close this out for now, feel free to re-open if needed.

@jurre jurre closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants