From 77c15cee7b37b332d5d0e9aa85dddf2742e9b0c8 Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Tue, 5 Nov 2024 21:25:54 +0000 Subject: [PATCH 1/8] make card flex on VeteranInformation --- .../pattern2/TaskBlue/VeteranInformation.jsx | 84 ++++++++++--------- .../pattern2/TaskOrange/config/form.js | 2 +- 2 files changed, 44 insertions(+), 42 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx index 9f2a3975a9d9..c41b96f00046 100644 --- a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx +++ b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx @@ -28,54 +28,56 @@ const VeteranInformation = ({ formData }) => {

Confirm the personal information we have on file for you.

- - - {`${first || ''} ${middle || ''} ${last || ''}`} - {suffix ? `, ${suffix}` : null} - - {veteranSocialSecurityNumber ? ( -

- Last 4 digits of Social Security number: - - {veteranSocialSecurityNumber.slice(-4)} - -

- ) : null} - {/* {vaFileLastFour ? ( */} - {/*

+

+ + + {`${first || ''} ${middle || ''} ${last || ''}`} + {suffix ? `, ${suffix}` : null} + + {veteranSocialSecurityNumber ? ( +

+ Last 4 digits of Social Security number: + + {veteranSocialSecurityNumber.slice(-4)} + +

+ ) : null} + {/* {vaFileLastFour ? ( */} + {/*

VA file number:{' '} - {mask(vaFileLastFour)} + {mask(vaFileLastFour)} -

- ) : null} */} -

- Date of birth: - {isValid(dobDateObj) ? ( +

+ ) : null} */} +

+ Date of birth: + {isValid(dobDateObj) ? ( + + {format(dobDateObj, FORMAT_READABLE_DATE_FNS)} + + ) : null} +

+

+ Gender: - {format(dobDateObj, FORMAT_READABLE_DATE_FNS)} + {genderLabels?.[gender] || ''} - ) : null} -

-

- Gender: - - {genderLabels?.[gender] || ''} - -

- +

+ +

diff --git a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/config/form.js b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/config/form.js index 99316f789808..e119a1767abc 100644 --- a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/config/form.js +++ b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/config/form.js @@ -32,7 +32,7 @@ const formConfig = { 'Please sign in again to resume your application for education benefits.', }, dev: { - showNavLinks: environment?.isLocalhost(), + showNavLinks: false, }, prefillEnabled: true, prefillTransformer, From ea34f07e59a5b1c20f821e74c79b0c58911e1037 Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Tue, 5 Nov 2024 21:31:14 +0000 Subject: [PATCH 2/8] remove shadow from cards --- .../patterns/pattern2/TaskBlue/ContactInfo.jsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/ContactInfo.jsx b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/ContactInfo.jsx index bd63137e7dbe..5bb35cf274d1 100644 --- a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/ContactInfo.jsx +++ b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/ContactInfo.jsx @@ -238,7 +238,6 @@ const ContactInfo = ({ const contactSection = [ keys.mobilePhone ? ( Date: Tue, 5 Nov 2024 21:33:27 +0000 Subject: [PATCH 3/8] remove note section for task blue profile info --- .../utils/data/task-blue/profile.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js b/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js index ddab1162730d..5b26f9fb3995 100644 --- a/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js +++ b/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js @@ -61,10 +61,6 @@ export const getContent = (appName = 'application') => ({ This is the contact information we have on file for you. We’ll send any updates or information about your {appName} to this address.

-

- Note: Any updates you make here will only be reflected - in this form. -

), From 00400309a1ca4c379394028d3172fe6ae62d57c9 Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Tue, 5 Nov 2024 22:47:04 -0700 Subject: [PATCH 4/8] add name label to card, update save button, add post study button --- .../pattern2/TaskBlue/VeteranInformation.jsx | 13 ++++++++----- .../TaskGray/form/components/EditContactInfo.jsx | 1 + .../utils/data/tabs.js | 7 +++++++ 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx index c41b96f00046..44bff575faa3 100644 --- a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx +++ b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx @@ -30,13 +30,16 @@ const VeteranInformation = ({ formData }) => {
- +

+ + Name:{' '} + {`${first || ''} ${middle || ''} ${last || ''}`} {suffix ? `, ${suffix}` : null} - +

{veteranSocialSecurityNumber ? (

Last 4 digits of Social Security number: diff --git a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/EditContactInfo.jsx b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/EditContactInfo.jsx index cfc72e77372e..f973877d8fbd 100644 --- a/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/EditContactInfo.jsx +++ b/src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/EditContactInfo.jsx @@ -85,6 +85,7 @@ export const BuildPage = props => { isDeleteDisabled cancelCallback={handlers.cancel} successCallback={handlers.success} + saveButtonText="Save to profile" />

diff --git a/src/applications/_mock-form-ae-design-patterns/utils/data/tabs.js b/src/applications/_mock-form-ae-design-patterns/utils/data/tabs.js index afb11412a5be..96ec987012d5 100644 --- a/src/applications/_mock-form-ae-design-patterns/utils/data/tabs.js +++ b/src/applications/_mock-form-ae-design-patterns/utils/data/tabs.js @@ -45,6 +45,13 @@ export const tabsConfig = { bgColor: '--vads-color-primary-dark', textColor: '--vads-color-white', }, + { + name: 'Post Study', + path: '/2/post-study', + description: 'Pattern 2 - Post Study Review', + bgColor: '--vads-color-warning', + textColor: '--vads-color-black', + }, ], }; From 79c59b1ed6d9cac33f01cb6713dbd3e15b99bdda Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Tue, 5 Nov 2024 23:22:35 -0700 Subject: [PATCH 5/8] clean up mock server, adjust mock data to match between tasks --- .../mocks/endpoints/address.js | 15 ----- .../mocks/endpoints/feature-toggles/index.js | 3 - .../endpoints/in-progress-forms/22-1990.js | 9 ++- .../endpoints/in-progress-forms/26-1880.js | 18 +++--- .../mock-form-ae-design-patterns.js | 8 ++- .../mocks/endpoints/user/index.js | 18 +++--- .../mocks/server.js | 61 ------------------- 7 files changed, 28 insertions(+), 104 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/address.js b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/address.js index f547edf19889..0c336611f3e6 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/address.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/address.js @@ -5,7 +5,6 @@ const mailingAddressUpdateReceived = { payload: { id: 311999, addressLine1: '123 Mailing Address St.', - addressLine2: 'Apt 1', addressType: 'DOMESTIC', city: 'Fulton', countryCodeIso3: 'USA', @@ -68,19 +67,6 @@ const homeAddressUpdateReceived = { }, }; -const homeAddressDeleteReceived = { - data: { - id: '', - type: 'async_transaction_va_profile_address_transactions', - attributes: { - transactionId: 'mock-delete-home-address-transaction-id', - transactionStatus: 'RECEIVED', - type: 'AsyncTransaction::VAProfile::AddressTransaction', - metadata: [], - }, - }, -}; - const mailingAddressUpdateReceivedPrefillTaskGreen = { data: { id: '', @@ -153,7 +139,6 @@ module.exports = { mailingAddressStatusSuccess, homeAddressUpdateReceived, homeAddressUpdateSuccess, - homeAddressDeleteReceived, addressValidation, addressValidationMatch, }; diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/feature-toggles/index.js b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/feature-toggles/index.js index 0fe7fbb1c1ff..9718a0c61b0b 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/feature-toggles/index.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/feature-toggles/index.js @@ -73,6 +73,3 @@ const generateFeatureTogglesState = ( }; module.exports = { generateFeatureToggles, generateFeatureTogglesState }; - -// File updated via API -// File updated via API diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/22-1990.js b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/22-1990.js index 9513994b2c85..5041e041fa8e 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/22-1990.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/22-1990.js @@ -14,12 +14,11 @@ const responses = { mobilePhone: '5554044567', email: 'test@test.com', veteranAddress: { - street: '1234 Fake St.', - street2: 'Apt Z', - city: 'Fort Collins', - state: 'CO', + street: '123 Mailing Address St.', + city: 'Futlon', + state: 'NY', country: 'USA', - postalCode: '80521', + postalCode: '97064', isMilitary: false, }, toursOfDuty: [ diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/26-1880.js b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/26-1880.js index 65a7395d5039..c6c92ab178a0 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/26-1880.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/26-1880.js @@ -1,20 +1,20 @@ const response = { formData: { fullName: { - first: 'Mark', - last: 'Webb', - suffix: 'Jr.', + first: 'Mitchell', + middle: 'George', + last: 'Jenkins', }, - dateOfBirth: '1950-10-04', + dateOfBirth: '1956-07-10', applicantAddress: { - street: '123 Faker Street', - city: 'Bogusville', - state: 'GA', + street: '123 Mailing Address St.', + city: 'Fulton', + state: 'NY', country: 'USA', - postalCode: '30058', + postalCode: '97064', }, contactPhone: '4445551212', - contactEmail: 'test2@test1.net', + contactEmail: 'test@test.com', periodsOfService: [ { serviceBranch: 'Air Force', diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/mock-form-ae-design-patterns.js b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/mock-form-ae-design-patterns.js index 8df769c45106..87d871992e04 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/mock-form-ae-design-patterns.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/in-progress-forms/mock-form-ae-design-patterns.js @@ -1,9 +1,13 @@ const prefill = { formData: { - veteranFullName: { first: 'Julio', middle: 'E', last: 'Hunter' }, + veteranFullName: { + first: 'Mitchell', + middle: 'George', + last: 'Jenkins', + }, gender: 'M', veteranDateOfBirth: '1950-11-18', - veteranSocialSecurityNumber: '796378321', + veteranSocialSecurityNumber: '123456789', homePhone: '6575107441', email: 'vets.gov.user+71@gmail.com', 'view:maritalStatus': { maritalStatus: 'MARRIED' }, diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/user/index.js b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/user/index.js index 8a0db5d4368c..1499e7400330 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/user/index.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/endpoints/user/index.js @@ -44,7 +44,7 @@ const baseUserResponses = { firstName: 'Mitchell', middleName: 'G', lastName: 'Jenkins', - birthDate: '1949-03-04', + birthDate: '1956-07-10', gender: 'M', zip: '97063', lastSignedIn: '2022-03-24T18:15:06.566Z', @@ -75,7 +75,7 @@ const baseUserResponses = { }, vaProfile: { status: 'OK', - birthDate: '19490304', + birthDate: '19560710', familyName: 'Jenkins', gender: 'M', givenNames: ['Mitchell', 'G'], @@ -141,7 +141,7 @@ const baseUserResponses = { vet360ContactInformation: { email: { createdAt: '2018-04-20T17:24:13.000Z', - emailAddress: 'myemail72585885@unattended.com', + emailAddress: 'test@test.com', effectiveEndDate: null, effectiveStartDate: '2019-03-07T22:32:40.000Z', id: 20648, @@ -220,7 +220,7 @@ const baseUserResponses = { badAddress: null, }, mobilePhone: { - areaCode: '619', + areaCode: '555', countryCode: '1', createdAt: '2022-01-12T16:22:03.000Z', extension: null, @@ -232,7 +232,7 @@ const baseUserResponses = { isTextPermitted: null, isTty: null, isVoicemailable: null, - phoneNumber: '5551234', + phoneNumber: '4044567', phoneType: 'MOBILE', sourceDate: '2022-02-17T20:15:44.000Z', sourceSystemUser: null, @@ -241,7 +241,7 @@ const baseUserResponses = { vet360Id: '1273766', }, homePhone: { - areaCode: '989', + areaCode: '555', countryCode: '1', createdAt: '2018-04-20T17:22:56.000Z', extension: null, @@ -253,7 +253,7 @@ const baseUserResponses = { isTextPermitted: null, isTty: null, isVoicemailable: null, - phoneNumber: '8981233', + phoneNumber: '8081234', phoneType: 'HOME', sourceDate: '2022-03-11T16:31:55.000Z', sourceSystemUser: null, @@ -302,11 +302,11 @@ const mockErrorResponses = { accountUuid: '7d9e2bfb-13ae-45c8-8764-ea3c87cd8af3', }, profile: { - email: 'vets.gov.user+75@gmail.com', + email: 'test@test.com', firstName: 'MITCHELL', middleName: 'G', lastName: 'JENKINS', - birthDate: '1949-03-04', + birthDate: '1956-07-10', gender: 'M', zip: '97063', lastSignedIn: '2022-03-24T18:15:06.566Z', diff --git a/src/applications/_mock-form-ae-design-patterns/mocks/server.js b/src/applications/_mock-form-ae-design-patterns/mocks/server.js index 182926ce357c..88ca88072312 100644 --- a/src/applications/_mock-form-ae-design-patterns/mocks/server.js +++ b/src/applications/_mock-form-ae-design-patterns/mocks/server.js @@ -3,7 +3,6 @@ const delay = require('mocker-api/lib/delay'); const user = require('./endpoints/user'); const address = require('./endpoints/address'); const emailAddress = require('./endpoints/email-addresses'); -const phoneNumber = require('./endpoints/phone-number'); const telephone = require('./endpoints/telephones'); const { generateFeatureToggles } = require('./endpoints/feature-toggles'); @@ -91,36 +90,11 @@ const responses = { return res.status(500).json(genericErrors.error500); } - // example user data cases return res.json(updateMemDb(req, user.loa3User72)); // default user LOA3 w/id.me (success) - // return res.json(user.dsLogonUser); // user with dslogon signIn.serviceName - // return res.json(user.mvhUser); // user with mhv signIn.serviceName - // return res.json(user.loa1User); // LOA1 user w/id.me - // return res.json(user.loa1UserDSLogon); // LOA1 user w/dslogon - // return res.json(user.loa1UserMHV); // LOA1 user w/mhv - // return res.json(user.badAddress); // user with bad address - // return res.json(user.nonVeteranUser); // non-veteran user - // return res.json(user.externalServiceError); // external service error - // return res.json(user.loa3UserWithoutLighthouseServiceAvailable); // user without lighthouse service available / no icn or participant id - // return res.json(user.loa3UserWithNoMobilePhone); // user with no mobile phone number - // return res.json(user.loa3UserWithNoEmail); // user with no email address - // return res.json(user.loa3UserWithNoEmailOrMobilePhone); // user without email or mobile phone - // return res.json(user.loa3UserWithNoHomeAddress); // home address is null - // return res.json(user.loa3UserWithoutMailingAddress); // user with no mailing address - // data claim users - // return res.json(user.loa3UserWithNoRatingInfoClaim); - // return res.json(user.loa3UserWithNoMilitaryHistoryClaim); }, 'OPTIONS /v0/maintenance_windows': 'OK', 'GET /v0/maintenance_windows': (_req, res) => { return res.json(maintenanceWindows.noDowntime); - - // downtime for VA Profile aka Vet360 (according to service name in response) - // return res.json( - // maintenanceWindows.createDowntimeActiveNotification([ - // maintenanceWindows.SERVICES.VA_PROFILE, - // ]), - // ); }, 'POST /v0/profile/address_validation': address.addressValidationMatch, 'GET /v0/profile/service_history': (_req, res) => { @@ -133,16 +107,11 @@ const responses = { // .json(serviceHistory.generateServiceHistoryError('403')); }, 'PUT /v0/profile/telephones': (req, res) => { - if (req?.body?.phoneNumber === '1111111') { - return res.json(phoneNumber.transactions.receivedNoChangesDetected); - } return res.json( updateMemDb(req, telephone.homePhoneUpdateReceivedPrefillTaskPurple), ); - // return res.status(200).json(phoneNumber.transactions.received); }, 'POST /v0/profile/telephones': (req, res) => { - // return res.status(200).json(phoneNumber.transactions.received); return res.json( updateMemDb( req, @@ -165,36 +134,6 @@ const responses = { // uncomment to test 401 error // return res.status(401).json(require('../tests/fixtures/401.json')); - // trigger NO_CHANGES_DETECTED response - // based on the text 'same' being put into address line 1 of ui - if (req?.body?.addressLine1 === 'same') { - return res.json(address.mailingAddressUpdateNoChangeDetected); - } - - // simulate a initial request returning a transactionId that is - // subsequently used for triggering error from GET v0/profile/status - // uncomment to test, and then uses the transactionId 'erroredId' in the status endpoint - // the status endpoint will return a COMPLETED_FAILURE status based on the string 'error' being in the transactionId - // return res.json( - // _.set( - // address.mailingAddressUpdateReceived, - // 'data.attributes.transactionId', - // 'erroredId', - // ), - // ); - - // to test the update that comes from the 'yes' action on the address change modal prompt, - // we can create a success response with a transactionId that is unique using date timestamp - // if (req.body.addressPou === 'CORRESPONDENCE') { - // return res.json( - // set( - // { ...address.mailingAddressUpdateReceived }, - // 'data.attributes.transactionId', - // `mailingUpdateId-${new Date().getTime()}`, - // ), - // ); - // } - // default response return res.json( updateMemDb(req, address.mailingAddressUpdateReceivedPrefillTaskGreen), From a6306df13bb783206d8eed341214803fc9bd38b9 Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Wed, 6 Nov 2024 00:46:00 -0700 Subject: [PATCH 6/8] test: update e2e tests for data changes --- .../tests/e2e/pattern1/taskGreen.cypress.spec.js | 4 ++-- .../tests/e2e/pattern1/taskPurple.cypress.spec.js | 10 +++++----- .../tests/e2e/pattern1/taskYellow.cypress.spec.js | 4 ++-- .../tests/e2e/pattern2/taskBlue.cypress.spec.js | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskGreen.cypress.spec.js b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskGreen.cypress.spec.js index 988461b1450a..3edadc748449 100644 --- a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskGreen.cypress.spec.js +++ b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskGreen.cypress.spec.js @@ -114,9 +114,9 @@ describe('Prefill pattern - Green Task', () => { cy.findByText('Mitchell G Jenkins').should('exist'); - cy.findByText('●●●–●●–8321').should('exist'); + cy.findByText('●●●–●●–6789').should('exist'); - cy.findByText('March 04, 1949').should('exist'); + cy.findByText('July 10, 1956').should('exist'); cy.findByText('Male').should('exist'); diff --git a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskPurple.cypress.spec.js b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskPurple.cypress.spec.js index 6f85b21093b0..42e94a2a223f 100644 --- a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskPurple.cypress.spec.js +++ b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskPurple.cypress.spec.js @@ -64,13 +64,13 @@ describe('Prefill pattern - Purple Task', () => { // check prefilled contact info page cy.url().should('contain', '/veteran-information'); cy.findByText('Home phone number').should('exist'); - cy.get('va-telephone[contact="9898981233"]').should('exist'); + cy.get('va-telephone[contact="5558081234"]').should('exist'); cy.findByText('Mobile phone number').should('exist'); - cy.get('va-telephone[contact="6195551234"]').should('exist'); + cy.get('va-telephone[contact="5554044567"]').should('exist'); cy.findByText('Email address').should('exist'); - cy.findByText('myemail72585885@unattended.com').should('exist'); + cy.findByText('test@test.com').should('exist'); cy.findByText('Mailing address').should('exist'); cy.findByText('123 Mailing Address St.').should('exist'); @@ -88,14 +88,14 @@ describe('Prefill pattern - Purple Task', () => { .as('homePhoneInput'); cy.get('@homePhoneInput').clear(); - cy.get('@homePhoneInput').type('9898985555'); + cy.get('@homePhoneInput').type('5558985555'); cy.findByTestId('save-edit-button').click(); // redirect to previous page and show save alert cy.url().should('contain', '/veteran-information'); cy.findByText('We’ve updated your home phone number').should('exist'); cy.findByText('Home phone number').should('exist'); - cy.get('va-telephone[contact="9898985555"]').should('exist'); + cy.get('va-telephone[contact="5558985555"]').should('exist'); // once the task is complete it should redirect to the pattern landing page cy.findByRole('button', { name: /Continue/i }).click(); diff --git a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskYellow.cypress.spec.js b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskYellow.cypress.spec.js index fd6a9d67f484..77a720928bb7 100644 --- a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskYellow.cypress.spec.js +++ b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern1/taskYellow.cypress.spec.js @@ -110,9 +110,9 @@ describe('Prefill pattern - Yellow Task', () => { cy.findByText('Mitchell G Jenkins').should('exist'); - cy.findByText('●●●–●●–8321').should('exist'); + cy.findByText('●●●–●●–6789').should('exist'); - cy.findByText('March 04, 1949').should('exist'); + cy.findByText('July 10, 1956').should('exist'); cy.findByText('Male').should('exist'); diff --git a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskBlue.cypress.spec.js b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskBlue.cypress.spec.js index 018de93460a7..b79a13524be7 100644 --- a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskBlue.cypress.spec.js +++ b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskBlue.cypress.spec.js @@ -135,10 +135,10 @@ describe('Prefill pattern - Blue Task', () => { cy.url().should('contain', '/veteran-information'); cy.findByText('Mobile phone number').should('exist'); - cy.get('va-telephone[contact="6195551234"]').should('exist'); + cy.get('va-telephone[contact="5554044567"]').should('exist'); cy.findByText('Email address').should('exist'); - cy.findByText('myemail72585885@unattended.com').should('exist'); + cy.findByText('test@test.com').should('exist'); cy.findByText('Mailing address').should('exist'); cy.findByText('123 Mailing Address St.').should('exist'); From 3177412ca897b015a3d9b0feb184899cd6b7d5c3 Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Wed, 6 Nov 2024 08:29:27 -0700 Subject: [PATCH 7/8] test: update orange task e2e test --- .../tests/e2e/pattern2/taskOrange.cypress.spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskOrange.cypress.spec.js b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskOrange.cypress.spec.js index 45154a2bea3b..89ab95f6928c 100644 --- a/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskOrange.cypress.spec.js +++ b/src/applications/_mock-form-ae-design-patterns/tests/e2e/pattern2/taskOrange.cypress.spec.js @@ -87,10 +87,10 @@ describe('Prefill pattern - Orange Task', () => { // check prefilled review page cy.url().should('contain', '/review-then-submit'); cy.findByText('Mailing address').should('exist'); - cy.findByText('1234 Fake St.').should('exist'); - cy.findByText('Fort Collins').should('exist'); - cy.findByText('CO').should('exist'); - cy.findByText('80521').should('exist'); + cy.findByText('123 Mailing Address St.').should('exist'); + cy.findByText('Futlon').should('exist'); + cy.findByText('NY').should('exist'); + cy.findByText('97064').should('exist'); cy.injectAxeThenAxeCheck(); }); From 044f797f77430bbd43e2bc49cb9c4498ad14d344 Mon Sep 17 00:00:00 2001 From: Adam Whitlock <8332986+adamwhitlock1@users.noreply.github.com> Date: Wed, 6 Nov 2024 09:51:54 -0700 Subject: [PATCH 8/8] remove description on task blue contact info --- .../utils/data/task-blue/profile.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js b/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js index 5b26f9fb3995..d6abdbf9e81b 100644 --- a/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js +++ b/src/applications/_mock-form-ae-design-patterns/utils/data/task-blue/profile.js @@ -55,14 +55,6 @@ import { */ export const getContent = (appName = 'application') => ({ title: 'Contact information', - description: ( - <> -

- This is the contact information we have on file for you. We’ll send any - updates or information about your {appName} to this address. -

- - ), // page titles & link aria-labels editHomePhone: 'Edit home phone number',