Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Storybook to use CSS-Library #3602

Open
2 tasks
Andrew565 opened this issue Dec 10, 2024 · 3 comments
Open
2 tasks

Migrate Storybook to use CSS-Library #3602

Andrew565 opened this issue Dec 10, 2024 · 3 comments
Assignees
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@Andrew565
Copy link
Contributor

Andrew565 commented Dec 10, 2024

Description

Component-library's Storybook is currently still setup to make use of Formation styles instead of styles from CSS-Library. In order to maintain consistency, Storybook should use CSS-Library's styles.

Details

imports can be found here: component-library/packages/storybook/.storybook/style.scss
Image

Tasks

  • Change formation imports into CSS-Library imports

Acceptance Criteria

  • Storybook works and displays all pages correctly

Estimating

Provide your estimate of 1, 2, 3, 5, 8 or 13
@Andrew565 - 5
@ataker - 3
@harshil1793 - 3
@it-harrison - 3
@jamigibbs -
@micahchiang - 5
@powellkerry - 5
@rmessina1010 - 5
@rsmithadhoc - 5

@caw310 caw310 added the DST-engineering Issues that require work from Design System Team engineers label Dec 11, 2024
@powellkerry
Copy link
Contributor

I don't think there is a 1-1 match as far as file names go. This may take a bit of investigation. I also don't think any of these imports are used? Testing locally, after deleting these instances, it looks like everything looks the same as in prod at first sight.

@Andrew565 Andrew565 self-assigned this Dec 23, 2024
@Andrew565
Copy link
Contributor Author

This ticket cannot be completed until #3640 is completed, blocked by lack of assets.

@caw310
Copy link
Contributor

caw310 commented Jan 3, 2025

Moving to a future sprint since this is blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

3 participants