Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade component-library to use node 20 #3484

Open
3 tasks
ataker opened this issue Nov 1, 2024 · 2 comments
Open
3 tasks

Upgrade component-library to use node 20 #3484

ataker opened this issue Nov 1, 2024 · 2 comments
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@ataker
Copy link
Contributor

ataker commented Nov 1, 2024

Description

Upgrade node version to 20

Details

This PR introduced unused unit tests. These tests couldn't be used because our current version of node, 18, does not support the type File natively.

If node 20 can't be upgraded to, please add a polyfill to support File in the tests in va-file-input-multiple.spec.todo.ts.

Tasks

  • Upgrade node in component-library to 20
  • If that's not possible, add polyfill to test file

Acceptance Criteria

  • The type File isn't causing tests in va-file-input-multiple.spec.todo.ts to fail
@ataker ataker added DST-engineering Issues that require work from Design System Team engineers platform-design-system-team labels Nov 1, 2024
@ataker
Copy link
Contributor Author

ataker commented Nov 1, 2024

In a test run through upgrading to node 20, the only issue I ran into was in packages/react-components/scripts/build.js, line 18
return new Buffer(
needed to be updated to
return Buffer.from(
as calling new Buffer has been deprecated

@ataker
Copy link
Contributor Author

ataker commented Nov 1, 2024

PR from the last time node was upgraded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

1 participant