Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table sorting - accessibility fixes #3455

Open
2 tasks
rsmithadhoc opened this issue Oct 29, 2024 · 1 comment
Open
2 tasks

Table sorting - accessibility fixes #3455

rsmithadhoc opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
accessibility Any Section 508 or accessibility issue DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-table DS Table component

Comments

@rsmithadhoc
Copy link
Contributor

rsmithadhoc commented Oct 29, 2024

Description

Accessibility fixes for the sortable table.

Details

  • Browser zoom in (on desktop) - when zoomed in, content gets cut-off, and there is no way to see it.

    • To remedy this, I believe the container around <table> will need to be made scrollable if there is any overflow, since we aren't going to stack the table like we would for the standard version. It's not the most ideal, ideally it wouldn't require any horizontal scrolling, but it will allow viewing of wider tables.
    display: block;
    width: 100%;
    overflow-x: auto;
    

    Image

  • Screen readers (all)/title text on buttons: If a column has been sorted in ascending order, then you tab to the next unsorted column with the double arrow the title says "Click to sort (column name) in descending order", but when you click it, it sorts in ascending order.
    Before:
    Image
    After:
    Image

  • Screen readers (all) - does not announce when the table is sorted. Currently, it sorts, but then reads out the button's new title attribute. We have aria-live="polite" SR text in there, but I believe focusing the button is overriding the reading of that text. I believe we do that because of a re-render of the table. We do want to maintain focus on the button, but I'm not sure how we can avoid re-rendering.

    • NVDA + Firefox & Narrator + Edge - sorting the table will repeat the table description "this is a sortable table with 5 rows and 8 columns", then reads the button title. I believe this is also from re-rendering.

Tasks

  • Fix accessibility issues.

Acceptance Criteria

  • Accessibility issues have been fixed.
@caw310
Copy link
Contributor

caw310 commented Oct 29, 2024

@caw310 caw310 added the DST-engineering Issues that require work from Design System Team engineers label Oct 29, 2024
@caw310 caw310 assigned rsmithadhoc and unassigned rsmithadhoc Nov 4, 2024
@ataker ataker self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Any Section 508 or accessibility issue DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-table DS Table component
Projects
None yet
Development

No branches or pull requests

3 participants