Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation - Step 1 - Discovery: Publishing multiple packages from the component-library #1954

Closed
4 tasks done
jamigibbs opened this issue Jul 31, 2023 · 6 comments
Assignees
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@jamigibbs
Copy link
Contributor

jamigibbs commented Jul 31, 2023

Description

We want to make a decision on how releases are going to work for the component library monorepo now that we have both the component-library and css-library. We are not going to want updates to the CSS Library included in the release notes for the Component Library. They are two separate packages and releases. Currently the component-library package gets published to NPM

Some discovery work was already started for this that we should leverage. We left off wanting to do some additional exploration with Lerna. Lerna was disregarded because it had a new maintainer but it has been almost a year and a lot can change in that time so I think it would be worthwhile evaluating it as an option too.

Details

Some things to keep in mind as we're working through this (taken from the original discovery ticket):

  • We want to make the process as easy as possible for engineers. There should be very little that we have to remember to do manually to make the publishing process happen correctly.
  • Whatever we choose it should be well-supported and well-documented
  • While for now we are only looking to publish two packages, in the future we may want to do something like publishing each of our components as an individual package. Whatever tool we choose should be able to handle that.

Tasks

Acceptance Criteria

  • Discovery details have been added to this ticket and presented to the team.
  • The team has a made a decision and has a path forward for how we will publish multiple packages from the component-library
@jamigibbs jamigibbs changed the title Publishing multiple packages from the component-library Discovery: Publishing multiple packages from the component-library Jul 31, 2023
@micahchiang
Copy link
Contributor

I wonder if we could modify our github action to only conditionally build and publish the css library. That probably doesn't solve the issue of needing separate release notes, but I wonder if that could be automated with a github action as well 🤔

@jamigibbs
Copy link
Contributor Author

That probably doesn't solve the issue of needing separate release notes

@micahchiang Yes I think the release notes were a big concern (although maybe not a major blocker if we need to get this package out the door sooner rather than later).

I'm not entirely sure the history or conversations in the past that pushed for Lerna or other monorepo build systems but we are not beholden to that direction (the original discovery work was done over a year ago). At one point too there was some discussion with bringing in this documentation repo to the component-library repo too (not everyone was entirely on board with that direction though).

If there is a simpler solution that we think will be easier to manage though, I'm all for it.

@micahchiang micahchiang changed the title Discovery: Publishing multiple packages from the component-library Formation Deprecation - Step 1 - Discovery: Publishing multiple packages from the component-library Oct 2, 2023
@caw310
Copy link
Contributor

caw310 commented Nov 2, 2023

@caw310 caw310 added the DST-engineering Issues that require work from Design System Team engineers label Nov 2, 2023
@it-harrison it-harrison self-assigned this Nov 14, 2023
@rmessina1010 rmessina1010 self-assigned this Nov 14, 2023
@caw310
Copy link
Contributor

caw310 commented Nov 21, 2023

Will carry over so that the findings from discovery can be shared with the team.

@it-harrison
Copy link
Contributor

Discovery document

@rmessina1010
Copy link
Contributor

Follow up ticket: #2293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

5 participants