-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus styles: Select color for focus style and identify other focus methods, if necessary #1314
Comments
This work isn't complete, but I've started thinking through some possible color options and wanted to share and explain the thinking here. The color explorations can be seen in the audit recommendations and notes doc I created. Some thoughts on why I went the direction I did in starting with those colors:
A few other thoughts on where I'm at with this work:
|
@davidakennedy - While working on the Back-to-Top change from button to link I came across the Scottish Design System's focus state (Laura, I think, also pointed me to it in another issue; great minds and all that). Instead of using a border ring for focus on buttons and links it flips the colors and adds a bottom inset drop shadow as a border. Worth a look I think: https://designsystem.gov.scot/styles/states/ |
Hi @davidakennedy - We're working on porting the VADS When the same scenario happens in VADS, the focus ring - which is currently yellow - wouldn't meet contrast guidance: I see you're working through this issue, so I wanted to bring it to your attention. Or if you have any thoughts, let us know. Thanks! |
@danbrady Thanks for the report! I'm not actively working on this, but definitely encourage you all to drop gotchas in this ticket so the team has it when work begins again. |
I've started to work on this between other team work. A few notes:
|
An update for this work:
Recommendation:
Why:
|
DK presented this to DSC during the Dec 19 meeting. DSC meeting notes: https://docs.google.com/document/d/15Sg_cifRNJMhseuUC6dxktQ0cLU5HidZ7OFeB2Djxpw/edit?usp=sharing |
Thanks, Carol! Some takeaways for me on next steps:
|
Context
The VA.gov Design System needs updated focus styles for better accessibility because the current styles don't meet color contrast guidelines in the Web Content Accessibility Guidelines. In updating the styles, we want to also think ahead to future versions of WCAG, which likely have more stringent requirements for focus styles.
Specifically, the current focus style fails to meet compliance in the scenario of white button on dark background (e.g. the active search button).
Links:
Work to be done
This work is to:
Feedback needed:
Acceptance criteria
The text was updated successfully, but these errors were encountered: