Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header names should be case-insensitve #4482

Open
ilopmar opened this issue Jul 6, 2020 · 1 comment
Open

Header names should be case-insensitve #4482

ilopmar opened this issue Jul 6, 2020 · 1 comment

Comments

@ilopmar
Copy link

ilopmar commented Jul 6, 2020

According to RFC 2616 - Hypertext Transfer Protocol -- HTTP/1.1, Section 4.2, "Message Headers"

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive

But the implementation when uploading files as multipart/form checks that the headers are capitalized: https://github.com/department-of-veterans-affairs/vets-api/blob/master/modules/vba_documents/lib/vba_documents/multipart_parser.rb#L64

Leading to an upload failure. That code (and any other code that check for header names) should be updated with a case-insensitive check of the headers.

@annaswims
Copy link
Contributor

@charleystran Did you see this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants