Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new operating status options to field_operating_status_facility #19805

Open
20 tasks
Agile6MSkinner opened this issue Nov 6, 2024 · 1 comment
Open
20 tasks
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices Vet Center CMS managed product owned by Facilities team

Comments

@Agile6MSkinner
Copy link

Agile6MSkinner commented Nov 6, 2024

Description

New options that we will provide editors for their facilities' operating status will need to be added to the values in field_operating_status_facility

New Values Are: NOT FINAL

  • Coming Soon
  • Relocating

This ticket can't ship until we have updated the form in #19807

Engineering notes / background

The form display UX for showing or hiding the "More information" textarea is addressed in va_gov_facilities/js/facility_status_details.es6.js. Because it uses "normal" or NOT "normal" as the condition, it should only need to be tested and does not require a code change.

Testing & QA

QA Test plan in ticket #19808

  • Need to check the form UX to confirm that all statuses that are not "Normal" require a "More information" field to show.

Scope / Impact analysis

What, if anything, could break as a result of this change?
Engineer should assess this when approaching PR.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

  • Functional testing:
  • Code review:
  • Design review:
  • Accessibility review:
  • Product acceptance:

Acceptance criteria

  • New options added to this field display on the relevant content types
    • nca_facility
    • health_care_local_facility
    • vba_facility
    • vet_center
    • vet_center_cap
    • vet_center_outstation
    • IEF on vamc_operating_status_and_alerts
  • All statuses that are not "Normal" require "More information" field to show (label= "Details")
    • Required
    • 300 character limit, with character counter displayed
  • Does this product have an existing regression test plan?
    • Yes, link:
    • No, regression test plan will be created as part of the work / points in this ticket
@Agile6MSkinner Agile6MSkinner changed the title Update API Push to LH for Operating Status Add new operating status options to field_operating_status_facility Nov 6, 2024
@jilladams jilladams added Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) labels Nov 6, 2024
@Agile6MSkinner Agile6MSkinner added VAMC CMS managed product owned by Facilities team Vet Center CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices and removed Needs refining Issue status labels Nov 6, 2024
@davidmpickett
Copy link
Contributor

davidmpickett commented Nov 6, 2024

@Agile6MSkinner @omahane I updated the ACs to include an explicit list of the Content Types that this field displays on. One of them that I almost forgot about is the IEF on the VAMC System Operating Status page. There's a backlog ticket to remove that IEF, but while it's still alive we should make sure it's accounted for.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

3 participants